Add rag enrichment and ingestion. #33413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudevdm
force-pushed
the
add-rag-ingestion-enrichment
branch
2 times, most recently
from
e50d908 to
e966cb7
Compare
claudevdm
force-pushed
the
add-rag-ingestion-enrichment
branch
6 times, most recently
from
ba5ef2a to
b759659
Compare
claudevdm
force-pushed
the
add-rag-ingestion-enrichment
branch
from
b759659 to
b2ad7ac
Compare
|
R: @damccorm |
claudevdm
force-pushed
the
add-rag-ingestion-enrichment
branch
from
b2ad7ac to
589023f
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
reviewed
Dec 20, 2024
sdks/python/apache_beam/ml/rag/enrichment/bigquery_vector_search.py
Outdated
Show resolved
Hide resolved
Comment on lines
+83
to
+85
| ... metadata_restriction_template=( | ||
| ... "check_metadata(metadata, 'language', '{language}')" | ||
| ... ) |
There was a problem hiding this comment.
This should just be a string, right?
Suggested change
| ... metadata_restriction_template=( | |
| ... "check_metadata(metadata, 'language', '{language}')" | |
| ... ) | |
| ... metadata_restriction_template="check_metadata(metadata, 'language', '{language}')" |
There was a problem hiding this comment.
I thought this is the syntax used to assign the string in a next line so it does not go past the 80 column width limit.
sdks/python/apache_beam/ml/rag/enrichment/bigquery_vector_search.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,304 @@ | |||
| # | |||
There was a problem hiding this comment.
Could we call this out in CHANGES.md (both the enrichment and ingestion pieces)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ingestion and enrichment components for rag pipelines.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.